Skip to content

Vision based Overhead tiles use radial occlusion on tokens with no vision #8411

Description

@Drental

What happened?

Users reported that foundry v10 roofs make it impossible for the GM to see anything under a roof while selecting an NPC token, as the new roofs reveal tokens and the background based on vision, which NPCs in many game systems (DnD 5e, pf2e, SWADE, etc.) don't have.

image

Giving all NPCs vision causes a great inconvenience to GM's, and has a big performance impact, which means it's by no means a preferred solution.

Anathema suggested "actors other than PC treat tiles as "full tile" in overhead mode.", which I think is reasonable.

Without a solution to this the premium content will have to remove all roofs in a patch, which I think would be a great shame as the new roofs, together with the FOW images make scenes in v10 really amazing to explore.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

set up a roof tile like this:

image

then move an NPC token under it. can be reproduced in swade, dnd5e, pf2e, and others

What core version are you reporting this for?

Foundry v10 build 288

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled

Activity

  1. added
    bugFunctionality which is not working as intended
    on Oct 23, 2022
  2. added
    tilesIssues related to Tiles and their appearance
    visionIssues related to Token vision and vision modes
    uxIssues focused on user experience improvements
    on Oct 23, 2022
  3. self-assigned this
    on Oct 25, 2022
  4. Fyorl commented on Oct 25, 2022

    @Fyorl
    Contributor

    I have a candidate fix for this but it involves changing the signature for some public and protected methods so it will probably have to wait until v11 unless we come up with an alternative solution.

  5. stwlam commented on Oct 25, 2022

    @stwlam

    I have a candidate fix for this but it involves changing the signature for some public and protected methods so it will probably have to wait until v11 unless we come up with an alternative solution.

    Can the new signature temporarily be handled via turning the parameter list into a single rest parameter and structurally determining which was passed to the method?

  6. Fyorl commented on Oct 26, 2022

    @Fyorl
    Contributor

    Can the new signature temporarily be handled via turning the parameter list into a single rest parameter and structurally determining which was passed to the method?

    In this case it involves changing the method's return value.

  7. assigned and unassigned on Nov 7, 2022
  8. aaclayton commented on Nov 9, 2022

    @aaclayton
    Contributor

    I was able to implement an improvement in this behavior without any breaking conseqeuences for V10 APIs, so this bug fix can go forward!

  9. Repository owner moved this from In Progress to Done in Foundry VTT - Version 10 Maintenanceon Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugFunctionality which is not working as intendedtilesIssues related to Tiles and their appearanceuxIssues focused on user experience improvementsvisionIssues related to Token vision and vision modes

Type

No type

Fields

Priority

None yet

Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions