feat: make Shipping Rule Cost Center optional with company default fallback (backport #57355)#57402
Open
mergify[bot] wants to merge 1 commit into
Open
feat: make Shipping Rule Cost Center optional with company default fallback (backport #57355)#57402mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
…llback (#57355) feat(shipping-rule): make cost center optional with company default fallback Cost Center on Shipping Rule is no longer mandatory. When left blank, the applied shipping tax row falls back to the company default cost center, avoiding the 'Cost Center is required for Profit and Loss account' error on submit. The rule's project is also applied to the tax row. (cherry picked from commit a47f258) # Conflicts: # erpnext/accounts/doctype/shipping_rule/shipping_rule.json
Contributor
Author
|
Cherry-pick of a47f258 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cost Center on the Shipping Rule was mandatory, so teams that do not track a cost center on shipping charges were still forced to pick one.
Change
Cost Center on the Shipping Rule is now optional. When it is left blank, the shipping charge added to the taxes table falls back to the company's default cost center. This avoids the "Cost Center is required for Profit and Loss account" error on submit, since shipping accounts are usually income accounts. The rule's Project is now applied to the shipping tax row as well (the field existed but was never being used).
How to test
no-docs
This is an automatic backport of pull request feat: make Shipping Rule Cost Center optional with company default fallback #57355 done by Mergify.