fix: show create payment entries as an inner button on row selection#57320
Open
Shllokkk wants to merge 1 commit into
Open
fix: show create payment entries as an inner button on row selection#57320Shllokkk wants to merge 1 commit into
Shllokkk wants to merge 1 commit into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5Safe to merge — the change is purely a UI wiring refactor in a single JS file with no database queries touched. The logic correctly handles all edge cases: the create_pe_btn guard in toggle_create_pe_button means the function is a no-op when the user lacks permission or when the datatable hasn't been built yet; after_refresh hides the button after unchecking all rows, which is the intended reset behavior; and no external code depended on the removed global namespace functions. No files require special attention. Reviews (1): Last reviewed commit: "fix: show create payment entries as an i..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Create Payment Entries action on the Accounts Payable report was placed in the page's primary-action slot. That slot is shared with the framework: when a report becomes a prepared report , core puts its "Generate New Report" button in the same slot. The Toggle/clear logic would then clobber that button, breaking prepared-report generation.
Fix
Moved the action to inner button instead.
Ref #56747