fix(stock): recalculate valuation rates on sales returns#57327
Draft
Sudharsanan11 wants to merge 2 commits into
Draft
fix(stock): recalculate valuation rates on sales returns#57327Sudharsanan11 wants to merge 2 commits into
Sudharsanan11 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
For partial returns of Delivery Notes and Sales Invoices with Update Stock enabled, the incoming valuation rate could remain zero for batched items.
This resulted in:
Reposting the voucher did not resolve the issue because Recalculate Valuation Rate only supported Purchase Receipts, Purchase Invoices, and Stock Entries.
Resolution
Extended valuation-rate recalculation to support:
Reposting now derives the incoming valuation rate from the original sales voucher and updates the related stock valuation records.
Validation
Added regression tests for partial returns of batched items through:
The tests verify that reposting restores the correct incoming rate and stock value difference.