fix: add reconciliation after submit logic for bank transactions#57330
Draft
ervishnucs wants to merge 1 commit into
Draft
fix: add reconciliation after submit logic for bank transactions#57330ervishnucs wants to merge 1 commit into
ervishnucs wants to merge 1 commit into
Conversation
ervishnucs
marked this pull request as ready for review
July 21, 2026 16:27
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5Safe to merge; the core tracking and reconciliation logic is correct and well-structured. The Map-keyed approach correctly scopes reconciliation to the exact doctype+name pair, the rename-tracking hooks are sound, and error handling exists for both failure modes. The one gap is a UX omission that does not cause data loss or incorrect reconciliation. erpnext/public/js/bank_reconciliation_tool/dialog_manager.js — the on_submit frappe.call callback's r.exc branch warrants a follow-up fix for consistent user guidance. Reviews (2): Last reviewed commit: "fix: add reconciliation after submit log..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
This issue breaks the reconciliation workflow when users create Payment Entries using the Edit in Full Page option. As a result, bank transactions remain unreconciled, requiring additional manual effort.
Steps to Reproduce: