Skip to content

chore(types): use a PEP634 pattern match in build_bulk_cites_doc - #8143

Open
cweider wants to merge 1 commit into
freelawproject:mainfrom
cweider:search-revise-match
Open

cweider wants to merge 1 commit into
freelawproject:mainfrom
cweider:search-revise-match

Conversation

@cweider

@cweider cweider commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Doing so allows the type checker to narrow. The match was introduced with 15855bb and used __name__ then. This was one addition among many - there's no indication that the string-based approach was material to the implementation.

Deployment

This PR should:

  • skip-deploy (skips everything below)
    • skip-web-deploy
    • skip-celery-deploy
    • skip-cronjob-deploy
    • skip-daemon-deploy

AI Disclosure

  • No AI tools were used to create the content of this PR.
  • Parts of this PR were created with the help of an AI tool, and I have carefully reviewed all of its content and take full responsibility for it.

Doing so allows the type checker to narrow. The `match` was
introduced with 15855bb and used `__name__` then. This was one
addition among many - there's no indication that the string-based
approach was material to the implementation.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@MorganBennetDev
MorganBennetDev self-requested a review October 11, 2026 21:24
@MorganBennetDev MorganBennetDev self-assigned this Oct 11, 2026
@MorganBennetDev MorganBennetDev added this to the 100% Type Coverage milestone Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

2 participants