fix(navigation-experimental): fix an issue where SaveableCloseable can reference to wrong SaveableStateHolder - #716
Merged
gabrielittner merged 1 commit intoMar 8, 2024
Conversation
…can reference to wrong `SaveableStateHolder` (e.g. due to configuration changes)
gabrielittner
approved these changes
Mar 8, 2024
gabrielittner
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this and fixing it
hoc081098
deleted the
fix-SaveableCloseable-ref-to-wrong-SaveableStateHolder
branch
March 8, 2024 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SaveableCloseableis longer thanSaveableStateHolder