Conversation
Uwuewsky
marked this pull request as draft
February 28, 2022 16:32
Uwuewsky
marked this pull request as ready for review
February 28, 2022 17:01
Author
|
Okay, I'll close PR. If anyone needs, see my repository. |
Owner
|
@Uwuewsky I'm not opposed to integrating some of these features – eventually – just haven't had time to work on the project really. Thanks for your work & maintaining a separate fork! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite
Overview
Mangadex-dl had serious problems related to the inability to download chapters with the same number separately and some others troubles.
This PR almost completely rewrites the code. In the new version:
Resolves #31, resolves #35
See README for more information.
Testing
I tested the program on OS Windows with Python 3.10.2. Some notable tested manga titles:
:in title (Windows).Current limitation