Skip to content

Simd improvement #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

Simd improvement #1278

merged 1 commit into from
Mar 19, 2024

Conversation

@laurentcau
Copy link

@laurentcau laurentcau commented Mar 15, 2024

  • Add simd aligned_vec3 (and sse aligned_dvec3 - 2 x xmm)
  • Fast packed_vec3 <=> aligned_vec3 and packed_vec4 <=> aligned_vec4 conversion
  • Fast aligned_vec3 <=> aligned_vec4 conversion
  • Optimized aligned_mat x aligned_mat and aligned_mat x aligned_vec
  • Inverse aligned_mat3 simd version (actually slower than ssid on my computer even it has 30% less instruction ?)

@laurentcau
Copy link
Author

laurentcau commented Mar 15, 2024

Note: I fixed the integer div issue reported there: #1255
I also added a test to check there will be no regression in the future.
For the template issues with GLM_FORCE_NEON, since there is no detail, I can't fix it.
All tests are compiling fine on my side with clang + neon. So that should be something not covered by tests but what ? @dimitre

@laurentcau laurentcau force-pushed the b7 branch 3 times, most recently from 5a553eb to 64038f9 Compare March 18, 2024 10:11
@laurentcau
Simd improvement
f5cd765 
- Add simd aligned_vec3 (and sse aligned_dvec3 - 2 x xmm)
- Fast packed_vec3 <=> aligned_vec3 and packed_vec4 <=> aligned_vec4 conversion
- Fast aligned_vec3 <=> aligned_vec4 conversion
- Optimized aligned_mat x aligned_mat and aligned_mat x aligned_vec
- Inverse aligned_mat3 simd version (actually slower than ssid on my computer even it has 30% less instruction ?)
@laurentcau
Copy link
Author

laurentcau commented Mar 19, 2024

Tests passed
https://github.com/laurentcau/glm/actions/runs/8326367556
@christophe-lunarg

@christophe-lunarg
Copy link

christophe-lunarg commented Mar 19, 2024

Considering you didn't receive any answer from the ARM NEON issue after multiple query, I think it's fair to break it and have been for who that matters submit a PR.

@christophe-lunarg
Copy link

christophe-lunarg commented Mar 19, 2024

Thanks for contributing!

@christophe-lunarg christophe-lunarg merged commit 4137519 into g-truc:master Mar 19, 2024
@remixer-dec remixer-dec mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laurentcau @christophe-lunarg