feat(ui): use dropdown selectors for camera brand, model, and lens profile selection - #1191
Open
namdamdoi68-oss wants to merge 1 commit into
Open
namdamdoi68-oss wants to merge 1 commit into
namdamdoi68-oss wants to merge 1 commit into
Conversation
Author
|
Hi @AdrianEddy @mycosd — PR is ready for review. All CI tests pass cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the plain text input fields in the camera calibration panel with structured
ComboBoxselectors linked to the built-in camera/lens profiles database. This prevents manual typing typos, ensures data validity, and streamlines the calibration workflow.Key Changes:
mapfield ofLensProfileDatabaseaspubinsrc/core/lens_profile_database.rsto allow querying profile metadata.get_camera_brands(),get_camera_models(brand), andget_lens_models(brand, model)tosrc/controller.rsto return sorted, unique lists of brands, models, and lenses.TableList.qmlto support the"type": "combobox"field mapping, displaying a styledComboBoxthat queries the database dynamically and supports autocompletion.LensCalibrate.qmlto use comboboxes, implementing cascading resets (changing brand clears model & lens) to prevent invalid profile configurations.Verified with
cargo test(all 98 tests pass successfully).