fix(pinact): canonical .pinact.yml needs version 3 + geolonia exemption#49
Merged
Conversation
The canonical pinact/.pinact.yml shipped in v1.15.0 was missing the
required `version: 3` schema field, so pinact v4 errors on it
("schema version is required"). Add it, plus two refinements proven in
the geolonia-infra-cdk pilot:
- `separator: " # "` so pins match the org's two-space comment style.
- A `rules` entry exempting `geolonia/*` from the 7-day cooldown: the
cooldown guards against hijacked third-party releases, but a brand-new
geolonia/.github reusable would otherwise be un-adoptable for a week
(no older release contains it). Still SHA-pinned; Dependabot maintains.
Docs updated to note the exemption.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR updates documentation and configuration for the Action Pinning Check workflow. Documentation about cooldown protection is reflowed for readability, and the pinact configuration explicitly requires v4+ while adding Geolonia-specific rules that exempt ChangesAction Pinning Check Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Secret Leak CheckOK No secrets detected in this PR's diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48. The canonical
pinact/.pinact.ymlshipped in v1.15.0 is missing the requiredversion: 3schema field, so pinact v4 errors on it (schema version is required). This adds it, plus two refinements proven in the geolonia-infra-cdk pilot (geolonia-infra-cdk#133):version: 3— required by pinact v4; without itpinact runaborts.separator: " # "— pins match the org two-space comment style (pinact default is one space).rulesexemptinggeolonia/*from the cooldown — the 7-day cooldown guards against a hijacked third-party release. We author and controlgeolonia/*releases ourselves, and a brand-newgeolonia/.githubreusable would otherwise be un-adoptable for a week (no older release contains it). Still SHA-pinned; Dependabot maintains them.Docs note the exemption.
Part of geolonia-operations#144 / epic geolonia-operations#142.
Summary by CodeRabbit
Documentation
Chores