docs(pinact): standard Dependabot cooldown is 8 days (one over min_age 7)#50
Merged
Conversation
…e 7) Dependabot counts cooldown in calendar days while pinact's --verify-min-age enforces an exact 168h floor; an 8-day cooldown guarantees Dependabot PRs clear the Action Pinning Check on arrival (see geolonia-infra-cdk#134/#135).
Secret Leak CheckOK No secrets detected in this PR's diff. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdates the "Action Pinning Check" docs and pinact comment to use an 8-day Dependabot cooldown (was 7), and adjusts wording to clarify the timing relationship with pinact's 168-hour minimum-age. ChangesDependabot Cooldown Documentation
Possibly related PRs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/workflows.md`:
- Around line 176-183: Update the explanatory comment in the pinact-check
template that currently reads "matching 7-day cooldown" to reflect the new 8-day
standard: change the phrasing to "matching 8-day cooldown" (or equivalent) so it
matches the documented cooldown.default-days: 8 and the surrounding explanation
about pinact's min_age of 7 and Dependabot's calendar-day behavior; locate the
comment in the pinact-check template near the cooldown discussion (search for
the string "7-day cooldown" or the YAML key cooldown.default-days) and edit the
sentence to reference 8 days.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 67bd2fad-7161-45c0-8b58-5771efb9f25a
📒 Files selected for processing (1)
docs/workflows.md
CodeRabbit (#50): the cooldown comment in pinact/.pinact.yml still said 'matching 7-day cooldown'. The cooldown is 8 (one over the 7-day min_age); the min_age references (7) elsewhere are correct and unchanged.
Secret Leak CheckOK No secrets detected in this PR's diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the cooldown fix from the infra-cdk pilot (geolonia-infra-cdk#135).
Dependabot counts
cooldownin calendar days while pinact--verify-min-ageenforces an exact 168h floor. At the day boundary Dependabot could open a SHA-pinned PR a few hours before pinact accepts the pin, producing a transient red Action Pinning Check (seen on geolonia-infra-cdk#134). Setting the standardcooldownto 8 (one day over the 7-daymin_age) guarantees Dependabot PRs clear the gate on arrival.pinactremains the hard 7-day floor; Dependabot just waits a day longer so it always clears it.Part of geolonia-operations#144 / epic geolonia-operations#142.
Summary by CodeRabbit