feat(techdocs): allow AWS account ID via vars (drop caller secrets block)#95
Conversation
Reusable workflows don't auto-inherit secrets (only vars), so the AWS account ID was the one setting forcing every caller to keep a secrets: block (or secrets: inherit, which zizmor flags). An account ID is a non-sensitive identifier, so read it from the vars context too: ...|| vars.AWS_ACCOUNT_ID || vars.TECHDOCS_AWS_ACCOUNT_ID Back-compat: secrets are still tried first, so existing callers are unaffected. Callers that set the org/repo variable can now drop the secrets: block entirely (down to permissions: + uses:). Closes #94
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe reusable Backstage TechDocs workflow was updated to add fallback resolution for the AWS account ID: it now checks ChangesAWS Account ID Fallback
Estimated code review effort: 1 (Trivial) | ~5 minutes Related issues: Suggested reviewers: geolonia workflow maintainers 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🛡️ Security suite
Note All security checks passed. Updated for |
Summary
Reusable workflows don't auto-inherit secrets — only the
varscontext. The AWS account ID was the one setting that forced every caller ofreusable-backstage-techdocs.ymlto keep asecrets:block (orsecrets: inherit, which the org Security suite flags via zizmorsecrets-inherit).Since an account ID is a non-sensitive identifier — and the org now has a
TECHDOCS_AWS_ACCOUNT_IDvariable — this adds avarsfallback to the account-ID cascade:Back-compat: secrets are tried first, so existing
secrets:/secrets: inheritcallers are unaffected. Callers relying on the org variable can now drop thesecrets:block entirely:Also updates the secret-input descriptions to point at the
varsalternative.Closes #94
Test plan
secrets:block publishes TechDocs successfully (verify on the first repo we simplify)Follow-up
Simplify individual consumers to drop their
secrets:block (e.g. geonicdb-infra-cdk'spublish-techdocs.yml), once this lands.Summary by CodeRabbit
Documentation
Bug Fixes