Harden sync-team-access workflow template (explicit perms + secrets)#98
Conversation
Match the already-hardened route-issue.yml template: add a contents: read ceiling and pass the OPS_DISPATCH_* dispatch secrets explicitly instead of secrets: inherit. Clears zizmor excessive-permissions and secrets-inherit for every repo that adopts this template from the New workflow picker.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🛡️ Security suite
Note All security checks passed. Updated for |
There was a problem hiding this comment.
Pull request overview
This PR hardens the sync-team-access workflow template by aligning it with other hardened templates in this repo, eliminating common zizmor findings for repos that adopt it via the workflow picker.
Changes:
- Add an explicit workflow token permission ceiling (
permissions: contents: read) to avoid repo-default token permissions. - Replace
secrets: inheritwith an explicit secrets mapping for onlyOPS_DISPATCH_CLIENT_IDandOPS_DISPATCH_APP_PRIVATE_KEY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What
Harden
workflow-templates/sync-team-access.ymlto match the already-hardenedroute-issue.ymltemplate:permissions: contents: readceiling, andOPS_DISPATCH_CLIENT_ID/OPS_DISPATCH_APP_PRIVATE_KEYdispatch secrets explicitly instead ofsecrets: inherit.Why
sync-team-access.ymlwas the last picker template still usingsecrets: inheritwith nopermissions:block, so any repo adopting it from the "New workflow" picker inherited two zizmor findings on first commit:excessive-permissions(default token, nopermissions:block)secrets-inherit(all secrets forwarded unconditionally)The reusable declares exactly these two secrets (
reusable-sync-team-access.yml->on.workflow_call.secrets) and needs no more thancontents: readat the caller (it dispatches via an App token), so the explicit form is a drop-in.Surfaced while adopting the Security Suite in
geolonia-design-system, where the same fix was applied to that repo's copy.Note
Reusable pin left at its current
v1.16.0(unchanged); this PR is scoped to the hardening only.