Fix error in Vincenty destination function, closes #186. - #194
Merged
Merged
Conversation
The test uses the same example as given by movable-type and mozilla/ichnaea and matches the output of geographiclib's geosolve online calculator.
Contributor
|
I recommend merging this pull request. It fixes an outright bug. |
cffk
added a commit
to cffk/geopy
that referenced
this pull request
May 6, 2017
pyproj, if available, in preference to geographiclib. Also incorporate hannosch's pull request geopy#194.
KostyaEsmukov
approved these changes
Mar 14, 2018
KostyaEsmukov
left a comment
Member
There was a problem hiding this comment.
Thank you for this! Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test uses the same example as given by movable-type.co.uk and mozilla/ichnaea and matches the output of geographiclib's geosolve online calculator. The test fails without the fix.
@jqnatividad any comments?