Name spans after the operation - #810
Merged
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Collaborator
Author
|
I don't expect this to be reviewed, I'll just merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traced GraphQL spans are currently named from the document's first root field (clue-request-query-observation), which can't distinguish two operations starting with the same field and leaves anonymous documents unnameable.
This adds a descriptor, a display name, supplied by the generator from the operation object's name → span clue-request-ObsQuery, plus a clue.descriptor attribute. Callers can provide a custom name if so desired