Repository navigation
Conversation
kmendell
force-pushed
the
feat_projects_add_custom_labels_to_compose_metadata_links
branch
from
October 4, 2026 03:49
4e6f259 to
08a7a65
Compare
Comment on lines
+430
to
+439
| const startingProjectLink = | ||
| !yamlContext.atKey && | ||
| yamlContext.path.length === 3 && | ||
| yamlContext.path[0] === 'x-arcane' && | ||
| yamlContext.path[1] === 'urls' && | ||
| typeof yamlContext.path[2] === 'number' && | ||
| /^\s*-\s+[\w.-]*$/.test(context.state.doc.lineAt(context.pos).text); | ||
| if (startingProjectLink) { | ||
| yamlContext.atKey = true; | ||
| yamlContext.parentPath = yamlContext.path; |
Contributor
There was a problem hiding this comment.
Scalar links get key completions When someone edits a valid string link such as
- service, this check treats the URL as a key. The editor then offers unrelated YAML snippets, including service; accepting one replaces the link value with service configuration. This makes it easy to accidentally turn a valid project link into invalid metadata.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/lib/components/code-editor/editor.svelte
Line: 430-439
Comment:
**Scalar links get key completions** When someone edits a valid string link such as `- service`, this check treats the URL as a key. The editor then offers unrelated YAML snippets, including `service`; accepting one replaces the link value with service configuration. This makes it easy to accidentally turn a valid project link into invalid metadata.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…tom_labels_to_compose_metadata_links # Conflicts: # backend/api/api_test.go # backend/pkg/projects/custom_labels.go Co-authored-by: kmendell <25576967+kmendell@users.noreply.github.com>
greptile-apps
Bot
dismissed
their stale review
October 10, 2026 20:34
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchm.*())What This PR Implements
Fixes: #4054
Changes Made
Testing Done
AI Tool Used (if applicable)
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.The PR appears safe to merge, with a non-blocking editor completion issue to address.
Fix with agent prompt
Summary
The PR adds optional labels to Compose project links, exposes labeled links while retaining the deprecated
urlsresponse field, and updates the project page and editor guidance.Reviews (2) · Last reviewed commit: "feat(projects): add custom labels to Com..."