feat(eval-harness): default retrieval to auto search - #589
Merged
Conversation
Move context retrieval into retrieval_strategy.build_context_block so evals use scope=auto with a 10k character budget, prepend the user-node summary, and drop per-type search limit constants. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
- Critical —
zep-eval-harness/config/evaluation_config/retrieval_strategy.py:72:build_context_block()now fetches the same user summary for every test case. With the default concurrency of 15, this creates many concurrentuser.get_node()calls per user, each potentially retrying nine times. This can trigger rate limits, substantially delay evaluations, and cause inconsistent context when only some lookups fail. Previously, the summary was fetched once per user. Fetch it once inevaluate_all_questions()and pass it intobuild_context_block(), or cache one task/result per user.
Avoid redundant user.get_node calls under concurrent evaluation by loading the summary once and passing it into build_context_block. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retrieval_strategy.build_context_block, defaulting toscope="auto"with a 10k character budget.user.get_node) and optionally concatenates document-graph auto search when--doc-runis set.Test plan
uv run zep_evaluate.py) and confirm context includes<USER_SUMMARY>plus auto-packed graph context--doc-run Nand confirm document context is appendedsearch_configurationshowsstrategy/scope/max_charactersMade with Cursor