args: remove mmap/mlock/dio flags from arg parser - #28334
Merged
Merged
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Member
Author
|
Server CIs are failing because the Edit: PR has been merged. |
ggerganov
approved these changes
Sep 8, 2026
ServeurpersoCom
approved these changes
Sep 8, 2026
Member
Author
|
CI failures unrelated to PR. Merging. |
1 task
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
pl752
pushed a commit
to pl752/llama.cpp
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
2 tasks
druide67
added a commit
to druide67/asiai-inference-server
that referenced
this pull request
Sep 16, 2026
#42) llama.cpp 0.4.1 removed --mlock/--mmap/--direct-io from its arg parser (ggml-org/llama.cpp#28334); every bundled llama.cpp daemon would refuse to start after the upgrade. --load-mode mmap+mlock is the exact equivalent and is accepted since 0.3.0. A test refuses any bundled manifest carrying a removed flag. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
zsogitbe
pushed a commit
to zsogitbe/llama.cpp
that referenced
this pull request
Sep 17, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #20834
I think it has been a decent amount of time since we deprecated the
--mmap,--mlock, and--direct-ioflags in favor for--load-mode. This PR completely removes any references of the flag from the arg parser as the final cleanup of the refactor.Requirements