Repository navigation
Fix shader/program info log leak and new[]/delete mismatch in CoreGL.cpp - #341
Open
Abishek82828 wants to merge 1 commit into
Open
Abishek82828 wants to merge 1 commit into
Abishek82828 wants to merge 1 commit into
Conversation
CheckShader() and CheckProgram() allocate infoLog with 'new char[infologLength]' but on the FILTER_GLSL_SPAM early-return path (the common case: ATI/Intel drivers reporting a clean compile/link) the buffer was never freed, leaking memory on essentially every successful shader compile on those GPUs. The non-leaking path also freed it with scalar 'delete' instead of 'delete[]', which is undefined behavior for an array allocation. Fixed both functions to free infoLog with delete[] on every return path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckShader()andCheckProgram()inCore/CoreGL.cppallocateinfoLogwithnew char[infologLength], but on theFILTER_GLSL_SPAMearly-return path — the common case, since it's hit whenever ATI or Intel drivers report a clean compile/link ("shader was successfully compiled", "no errors", "...linked") — the buffer was never freed. SinceFILTER_GLSL_SPAMis enabled by default, this leaksinfologLengthbytes on essentially every successful shader/program compile on those GPU vendors.On the non-leaking path, the buffer was freed with scalar
delete infoLog;instead ofdelete[] infoLog;, which is undefined behavior for an array allocation.Fix: free
infoLogwithdelete[]on every return path in both functions.Small, self-contained change, no behavior change on the non-leak path. Built and linked cleanly on VC++ (win64) before submitting.