Skip to content

Fix LAUGH reaction emoji#746

Merged
laymonage merged 1 commit into
giscus:mainfrom
ouuan:fix-laugh-emoji
Oct 26, 2022
Merged

Fix LAUGH reaction emoji#746
laymonage merged 1 commit into
giscus:mainfrom
ouuan:fix-laugh-emoji

Conversation

@ouuan

@ouuan ouuan commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

The link to the image of the LAUGH reaction on GitHub is https://github.githubassets.com/images/icons/emoji/unicode/1f604.png.

The emoji of Unicode 1f604 is "😄" instead of "😆", according to https://www.unicode.org/charts/nameslist/n_1F600.html.

BTW, when this PR body is displayed on GitHub, you can see that "😄" is the one that appears the same as the reaction on GitHub.

The link to the image of the LAUGH reaction on GitHub is
<https://github.githubassets.com/images/icons/emoji/unicode/1f604.png>.

The emoji of Unicode 1f604 is "😄" instead of "😆", according to
<https://www.unicode.org/charts/nameslist/n_1F600.html>.
@vercel

vercel Bot commented Oct 26, 2022

Copy link
Copy Markdown

@ouuan is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Oct 26, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
giscus ✅ Ready (Inspect) Visit Preview Oct 26, 2022 at 8:04AM (UTC)

@laymonage

Copy link
Copy Markdown
Member

Thanks! Surprised I didn't notice this earlier 😄

@laymonage
laymonage merged commit 98bae32 into giscus:main Oct 26, 2022
@ouuan
ouuan deleted the fix-laugh-emoji branch October 26, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants