Skip to content

Update some style#1030

Merged
laymonage merged 2 commits into
giscus:mainfrom
rea1shane:feature-update-html
Jun 25, 2023
Merged

Update some style#1030
laymonage merged 2 commits into
giscus:mainfrom
rea1shane:feature-update-html

Conversation

@rea1shane

@rea1shane rea1shane commented May 9, 2023 •
edited
Loading

Copy link
Copy Markdown

light.css before:

image

light.css after:

image

befor:

image

after:

image

before:

image

after:

image

before:

image

after:

image

@vercel

vercel Bot commented May 9, 2023

Copy link
Copy Markdown

@rea1shane is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

@rea1shane

rea1shane commented May 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

EDIT: github style like the before, and I prefer the after

before:

image

after:

image

@rea1shane

rea1shane commented May 11, 2023

Copy link
Copy Markdown
Author

before on phone:

image

after on phone:

image

@rea1shane

rea1shane commented May 12, 2023

Copy link
Copy Markdown
Author

reply header before:

image

after:

image

@rea1shane

rea1shane commented May 16, 2023

Copy link
Copy Markdown
Author

before:

image

after:

image image

@rea1shane

rea1shane commented May 16, 2023

Copy link
Copy Markdown
Author

Hi @laymonage , everything almost done, plz review it in your free time~

@rea1shane

rea1shane commented May 17, 2023

Copy link
Copy Markdown
Author

before:

image

after:

image

@rea1shane

rea1shane commented May 17, 2023

Copy link
Copy Markdown
Author

before:

image

after:

image

@rea1shane

rea1shane commented May 17, 2023

Copy link
Copy Markdown
Author

before:

image

after:

image

@rea1shane

rea1shane commented May 17, 2023

Copy link
Copy Markdown
Author

table in reply

dark theme before:

image

after:

image

light theme before:

image

after:

image

Same as GitHub style.

@rea1shane

rea1shane commented May 17, 2023

Copy link
Copy Markdown
Author

Everything done!

@rea1shane

rea1shane commented Jun 9, 2023

Copy link
Copy Markdown
Author

Hi @laymonage . Will you merge this PR? If not, please let me know. I need these changes. Waiting for your reply!

@rea1shane

rea1shane commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

@laymonage Did you miss this PR 👀

laymonage
laymonage reviewed Jun 25, 2023
View reviewed changes
Comment thread .stylelintrc.js Outdated
Comment thread components/Reply.tsx Outdated
Comment thread styles/base.css Outdated
Comment thread styles/base.css Outdated
Comment thread styles/base.css Outdated
Comment thread styles/themes/light.css Outdated
Comment thread styles/base.css Outdated
Comment thread styles/base.css Outdated
Comment thread styles/base.css Outdated
Comment thread styles/base.css Outdated
@laymonage
laymonage merged commit 0c5dbed into giscus:main Jun 25, 2023
@rea1shane

rea1shane commented Jun 26, 2023

Copy link
Copy Markdown
Author

Sorry for the various errors, I'm new to front-end, thanks for your advice.

@rea1shane
rea1shane deleted the feature-update-html branch June 26, 2023 05:03
rea1shane
rea1shane commented Jun 26, 2023
View reviewed changes
Comment thread components/Giscus.tsx
rea1shane
rea1shane commented Jun 26, 2023
View reviewed changes
Comment thread components/Comment.tsx
@rea1shane rea1shane mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laymonage laymonage laymonage left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rea1shane @laymonage @zkeq