Skip to content

Add Israel localization (Hebrew Language)#1056

Merged
laymonage merged 1 commit into
giscus:mainfrom
ladunjexa:main
Jun 24, 2023
Merged

Add Israel localization (Hebrew Language)#1056
laymonage merged 1 commit into
giscus:mainfrom
ladunjexa:main

Conversation

@ladunjexa

Copy link
Copy Markdown
Contributor

Add new localization, Israel, accurately hebrew translation following step-by-step to add a new localization.

Accomplished:

  • Copy one of the directories in locales and rename the new directory into your language's code.
  • Open common.json and config.json inside the directory.
  • Start translating the strings. Make sure to follow your language's plural rules for translation keys with an object as the value (e.g. those that require {{ count }}).
  • Copy one of the README files and name it README.[code].md, e.g. README.id.md and translate the content. Add your language to the bottom of the new README and all the existing READMEs.
  • Edit i18n.tsx and update the following variables:
  • availableLanguages: include your language code and name.
  • dateFormatters, shortDateFormatters, shortDateYearFormatters, and relativeTimeFormatters: include new objects with your language code, following the existing languages.
  • Edit i18n.json and include your language.
  • In all of the aforementioned files, make sure that the language list is sorted by the language code.
  • Create a PR with your localization updates.

@vercel

vercel Bot commented May 29, 2023

Copy link
Copy Markdown

@ladunjexa is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Jun 24, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giscus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2023 7:04pm

@laymonage

laymonage commented Jun 24, 2023

Copy link
Copy Markdown
Member

Thanks, I've rebased, squashed, and made minor edits (sort the language list alphabetically and add he to the rtlLanguages list).

@laymonage
laymonage merged commit 7c7d479 into giscus:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants