Add security headers#147
Merged
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/laymonage/giscus/71KCJx164MUfi4HR2qrwwiyyzu5M |
laymonage
force-pushed
the
security-headers
branch
from
July 25, 2021 05:53
2bdccac to
ca638c6
Compare
laymonage
force-pushed
the
security-headers
branch
from
July 25, 2021 06:00
ca638c6 to
fd6faad
Compare
The browser will refuse to load the iframe anyway
laymonage
force-pushed
the
security-headers
branch
from
July 25, 2021 06:00
fd6faad to
480fc72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40.
Slightly related to utterance/utterances#527, we set
Content-Security-Policywithframe-ancestorsthat's set to the current origin if it's allowed according togiscus.jsonsettings. As a result, we no longer show the message implemented in #125 (the browser will now simply refuse to load theiframe).