Add Czech (cs) Language Support#1561
Merged
Merged
Conversation
|
@Jekwwer is attempting to deploy a commit to the giscus Team on Vercel. A member of the Team first needs to authorize it. |
laymonage
reviewed
Nov 28, 2024
Comment on lines
+20
to
+24
| "replies": { | ||
| "0": "{{count}} odpovědí", | ||
| "one": "{{count}} odpověď", | ||
| "two": "{{count}} odpovědi", | ||
| "three": "{{count}} odpovědi", | ||
| "four": "{{count}} odpovědi", | ||
| "other": "{{count}}{{plus}} odpovědí" | ||
| }, |
Member
There was a problem hiding this comment.
The format for Czech according to CLDR is one, few, many, and other. If we don't follow it, we get the following bug (note the "replies" at the bottom right):
I'm going to change two to few, remove three, and change four to many – hope that's OK.
laymonage
force-pushed
the
add-cs-localization
branch
from
November 28, 2024 17:19
809d4b4 to
7cd88b2
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laymonage
approved these changes
Nov 28, 2024
Member
|
Díky! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
csdirectory underlocales, withcommon.jsonandconfig.jsontranslated to Czech.README.cs.mdfor Czech language documentation.i18n.tsxto addcsinavailableLanguagesand Czech-specific date and time formatters.i18n.jsto addcsin the list of supported languages, sorted alphabetically by language code.Testing:
yarn devand inspecting the UI for correct display across different elements.Additional Notes: