Romanian translation for giscus#196
Conversation
|
@samarulmeu is attempting to deploy a commit to the giscus Team on Vercel. A member of the Team first needs to authorize it. |
laymonage
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR!
Could you also add the few category for the plurals? Looks like it's needed for Romanian: https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html#ro
Without it, some strings don't show up correctly:
|
Hope this is OK now. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/giscus/giscus/C3fpGYzKi1aH66FdJm9aHbtvuEsR |
|
Thanks @samarulmeu! The multi-language support isn't documented yet, but you should already be able to try this by adding If there are updates to giscus that require new translations, I hope you don't mind if I ping you for review! 😄 |
|
Thank you so much, @laymonage! And do please ping me. I really have faith in this project and really want to use it on my blogs. As a side note, is there a way to export the comments or backup them? |
|
@samarulmeu you can write a script that fetches the data from GitHub's API. It would not be within the scope of this project, though. I could try writing it just for fun when I have the time, but I'd create a new repository for that. It does sound interesting and useful. |
|
@laymonage I will try it. I think that backup is very important as, in the end, Discussions is owned by GitHub and accidents can happen (no access to the repository, suspended access, etc). Although I do not know if you can later import them in a new repository. |
|
@samarulmeu yeah, I agree on that. Importing is possible, with a few caveats because the imported discussions and comments will be made as new ones. Some caveats I can think of right now:
Original information for (1) and (2) can still be shown by including it in the comment body, e.g.
|
|
@laymonage I did not take into account this. I agree that this are some caveats, but still I think is better to have a backup instead of nothing. |
No description provided.