Skip to content

French translation of public interface#202

Merged
laymonage merged 1 commit into
giscus:mainfrom
larmarange:french
Oct 26, 2021
Merged

French translation of public interface#202
laymonage merged 1 commit into
giscus:mainfrom
larmarange:french

Conversation

@larmarange

@larmarange larmarange commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Oct 22, 2021

Copy link
Copy Markdown

@larmarange is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

laymonage
laymonage reviewed Oct 24, 2021
View reviewed changes

@laymonage laymonage left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! Would you be willing to translate the strings in common.json (and possibly the README.md) as well?

@larmarange

larmarange commented Oct 25, 2021

Copy link
Copy Markdown
Contributor Author

I will try to, but it may take few days (quite overloaded at work this week)

@laymonage

laymonage commented Oct 26, 2021

Copy link
Copy Markdown
Member

I will try to, but it may take few days (quite overloaded at work this week)

No worries. However, if you'd like me to merge this now so you can use it on your website right away, let me know!

@larmarange

larmarange commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

Hi @laymonage

I found some time to translate README.md and common.json as well.

Regards

@vercel

vercel Bot commented Oct 26, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/giscus/giscus/2NVBMiS3o5W5aPerCvUZFkdMt9dr
✅ Preview: https://giscus-git-fork-larmarange-french-giscus.vercel.app

@laymonage
laymonage merged commit f12f93f into giscus:main Oct 26, 2021
@laymonage

laymonage commented Oct 26, 2021

Copy link
Copy Markdown
Member

Thank you very much @larmarange! I might ping you later if we have new strings to translate, I hope you don't mind!

@larmarange
larmarange deleted the french branch October 26, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laymonage laymonage laymonage left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larmarange @laymonage