Skip to content

Add translation for Russian language#355

Merged
laymonage merged 1 commit into
giscus:mainfrom
Kanaduchi:add_ru_loc
Jan 26, 2022
Merged

Add translation for Russian language#355
laymonage merged 1 commit into
giscus:mainfrom
Kanaduchi:add_ru_loc

Conversation

@Kanaduchi

@Kanaduchi Kanaduchi commented Jan 17, 2022

Copy link
Copy Markdown

No description provided.

@vercel

vercel Bot commented Jan 17, 2022

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

laymonage
laymonage reviewed Jan 19, 2022
View reviewed changes

@laymonage laymonage left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments.

Comment thread locales/ru/config.json
@@ -0,0 +1,82 @@
{

@laymonage laymonage Jan 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also translate this file?

@Kanaduchi Kanaduchi Jan 19, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread locales/ru/common.json
Comment on lines +3 to +7
"0": "{{count}} откликов",
"one": "{{count}} отклик",
"few": "{{count}} отклика",
"other": "{{count}} откликов"

@laymonage laymonage Jan 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this (and other cardinal-based values) to follow the cardinal rule for the Russian language according to this page?

i.e. add the missing "many" key.

@Kanaduchi Kanaduchi Jan 19, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@vercel

vercel Bot commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/giscus/giscus/3wqHDcshmukyCj8tEim4cjTnt5jb
✅ Preview: https://giscus-git-fork-kanaduchi-addruloc-giscus.vercel.app

@laymonage
laymonage merged commit ed3c4f9 into giscus:main Jan 26, 2022
@laymonage

laymonage commented Jan 26, 2022

Copy link
Copy Markdown
Member

Спасибо!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laymonage laymonage laymonage left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kanaduchi @laymonage