Resize iframe with ResizeObserver#392
Merged
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/giscus/giscus/FPjVa9hWQNenfJXX4sarsu5NZqwm |
ResizeObserver
laymonage
force-pushed
the
resize-message
branch
from
February 9, 2022 05:21
1d51e90 to
8dace7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces iframe-resizer with a custom solution using the modern built-in
ResizeObserver. I'd love to remove theiframeResizer.contentWindow.min.jsscript from our widget page, but that'd be a breaking change to the giscus-component users until they (and I) update it to useResizeObserver. We'll have to do that sooner or later, but for now let's just set the script's strategy tolazyOnload.This saves us ~6KB in the client. We can save an additional 5KB if we completely remove the
contentWindowscript from the widget page. Probably would save even more in giscus-component.