Fix: Console launch fails when Windows username contains spaces - #12841
Merged
mstv merged 2 commits intoFeb 18, 2026
Merged
Conversation
…es with spaces (gitextensions#11259) GetEnvironmentVariable("ProgramW6432") can return null and AppSettings.LinuxToolsDir defaults to "", both causing Path.Combine to produce invalid paths. Add null/empty checks before each lookup and add test coverage for path quoting with spaces.
RussKie
approved these changes
Feb 17, 2026
gerhardol
approved these changes
Feb 17, 2026
mstv
reviewed
Feb 18, 2026
mstv
left a comment
Member
There was a problem hiding this comment.
LGTM
Could you add your sign-off to contributors.txt, please?
Contributor
Author
|
mstv
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathUtil.TryFindShellPathto preventPath.Combinefrom throwing or producing invalid paths whenProgramW6432env var is null orAppSettings.LinuxToolsDiris empty (both common when the Windows username contains spaces, e.g. "Acker Liu")TryFindShellPathnull-safety andQuote/QuoteNEwith space-containing pathsGetChangeDirCommandandExecutableCommandLinepatterns produce correctly quoted output for paths with spacesFixes #11259
Test plan
dotnet test --filter PathUtilTest— new tests pass, existing tests unaffecteddotnet test --filter ShellTests— new shell quoting tests pass