Skip to content

fix(launch): use a clear cancel label in the shortlink confirmation dialog#1677

Merged
nevo-david merged 2 commits into
mainfrom
fix/shortlink-dialog-cancel-label
Jul 23, 2026
Merged

fix(launch): use a clear cancel label in the shortlink confirmation dialog#1677
nevo-david merged 2 commits into
mainfrom
fix/shortlink-dialog-cancel-label

Conversation

@giladresisi

@giladresisi giladresisi commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Problem

When scheduling a post with links, the "Do you want to shortlink the URLs?" confirmation dialog answered with "Yes, shortlink it!" / "No, cancel!". The cancel label is misleading — it reads like it aborts posting altogether, when it actually just posts with the original URLs.

Changes

  • Pass a custom cancel label — "No, original URLs" — at the shortlink call site in manage.modal.tsx, using the existing (previously unused there) cancelButton parameter of deleteDialog. All other deleteDialog usages keep the default "No, cancel!".
  • Add the no_original_urls key to the English source translations and run lingo.dev to translate it across all 14 target locales (i18n.lock updated).
  • Hand-fix 8 machine translations (ja, ko, ar, tr, zh, bn, ru, vi) that rendered the label as a statement of absence ("there are no original URLs") instead of a choice ("No, keep the original URLs"), matching each locale's existing button-label style.

Testing

Manually tested locally: the dialog now shows "Yes, shortlink it!" / "No, original URLs", and both choices schedule the post with/without shortlinked URLs respectively. All 16 locale JSON files verified to parse.

🤖 Generated with Claude Code

@giladresisi @claude
fix(launch): use a clear cancel label in the shortlink confirmation d…
1dc655d 
…ialog

The shortlink question dialog used the generic "No, cancel!" cancel
label, which reads as aborting the whole post instead of declining
shortlinks. Pass a custom cancel label ("No, original URLs") via the
existing deleteDialog cancelButton param.

Adds the no_original_urls key to the English source, translates it to
all 14 lingo.dev locales, and hand-fixes 8 machine translations that
rendered the label as "there are no original URLs" instead of a choice.

Manually tested locally: the dialog now shows "Yes, shortlink it!" /
"No, original URLs", and both choices schedule the post with/without
shortlinked URLs accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@postiz-contribution postiz-contribution Bot added the contribution:approved Approved contributor label Jul 5, 2026
@postiz-contribution

postiz-contribution Bot commented Jul 5, 2026

Copy link
Copy Markdown

Contribution-checker quality warning
Heuristic score: 20/100 (low). This is a non-blocking warning surfaced by the project's quality settings.

Heuristics that flagged:

  • Excessive inline code references: 6 inline refs (>3)
  • PR doesn't use the repo's PR template: 5 required checkbox items missing (max 1, match ≥80%)
  • Body adds too many extra headers beyond the template: 3 extra headers (>1)
  • AI watermark phrase: Matched: "Generated with Claude Code"
  • Commit message too long: Longest: 758 chars

If this is a genuine contribution, please add detail to your PR description and tighten the diff scope before reviewers look at it.

@postiz-agent

postiz-agent Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

sentry[bot]
sentry Bot reviewed Jul 5, 2026
View reviewed changes
Comment thread apps/frontend/src/components/new-launch/manage.modal.tsx
Comment on lines +378 to +380
t('yes_shortlink_it', 'Yes, shortlink it!'),
undefined,
t('no_original_urls', 'No, original URLs')

This comment was marked as outdated.

Sign in to view

@giladresisi giladresisi Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in followup commit

@giladresisi @claude
fix(i18n): add missing no_original_urls key to ka_ge locale
ec91d10 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@postiz-contribution

postiz-contribution Bot commented Jul 14, 2026

Copy link
Copy Markdown

Contribution-checker quality warning
Heuristic score: 20/100 (low). This is a non-blocking warning surfaced by the project's quality settings.

Heuristics that flagged:

  • Excessive inline code references: 6 inline refs (>3)
  • PR doesn't use the repo's PR template: 5 required checkbox items missing (max 1, match ≥80%)
  • Body adds too many extra headers beyond the template: 3 extra headers (>1)
  • AI watermark phrase: Matched: "Generated with Claude Code"
  • Commit message too long: Longest: 758 chars

If this is a genuine contribution, please add detail to your PR description and tighten the diff scope before reviewers look at it.

@nevo-david
nevo-david merged commit fd4a816 into main Jul 23, 2026
11 checks passed
@nevo-david
nevo-david deleted the fix/shortlink-dialog-cancel-label branch July 23, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sentry sentry[bot] sentry[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution:approved Approved contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladresisi @nevo-david