Skip to content

Allow missing type parameters to work with cli#271

Merged
glebm merged 2 commits into
glebm:masterfrom
heironimus:fix-missing-command
Dec 7, 2017
Merged

Allow missing type parameters to work with cli#271
glebm merged 2 commits into
glebm:masterfrom
heironimus:fix-missing-command

Conversation

@heironimus

@heironimus heironimus commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

i18n-tasks missing -tdiff was ignoring the type field

@heironimus

heironimus commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

I fixed the Rubocop warnings I introduced. The others are on code that is quite old, so something changed in the build process. I'm hesitant to change them without knowing more context. They are all of the form Style/StderrPuts: Use warn instead of $stderr.puts. It seems reasonable to change to warn but I would prefer someone else's thoughts before I change.

The rbx build is also failing with the following: I'm glad to try to help, but I'm not familiar with Travis.

The command "eval bundle install --without debug --path=${BUNDLE_PATH:-vendor/bundle} " failed. Retrying, 2 of 3.
Ignoring json-1.8.6 because its extensions are not built. Try: gem pristine json --version 1.8.6
Ignoring psych-2.0.17 because its extensions are not built. Try: gem pristine psych --version 2.0.17
Ignoring racc-1.4.14 because its extensions are not built. Try: gem pristine racc --version 1.4.14
Ignoring rubinius-melbourne-3.9 because its extensions are not built. Try: gem pristine rubinius-melbourne --version 3.9
Ignoring rubysl-bigdecimal-2.0.2 because its extensions are not built. Try: gem pristine rubysl-bigdecimal --version 2.0.2
Ignoring rubysl-curses-2.0.1 because its extensions are not built. Try: gem pristine rubysl-curses --version 2.0.1
Ignoring rubysl-digest-2.0.8 because its extensions are not built. Try: gem pristine rubysl-digest --version 2.0.8
Ignoring rubysl-etc-2.0.3 because its extensions are not built. Try: gem pristine rubysl-etc --version 2.0.3
Ignoring rubysl-fcntl-2.0.4 because its extensions are not built. Try: gem pristine rubysl-fcntl --version 2.0.4
Ignoring rubysl-io-console-2.0.0 because its extensions are not built. Try: gem pristine rubysl-io-console --version 2.0.0
Ignoring rubysl-nkf-2.0.1 because its extensions are not built. Try: gem pristine rubysl-nkf --version 2.0.1
Ignoring rubysl-openssl-2.9 because its extensions are not built. Try: gem pristine rubysl-openssl --version 2.9
Ignoring rubysl-pty-2.0.3 because its extensions are not built. Try: gem pristine rubysl-pty --version 2.0.3
Ignoring rubysl-syslog-2.1.0 because its extensions are not built. Try: gem pristine rubysl-syslog --version 2.1.0
Ignoring rubysl-zlib-2.0.1 because its extensions are not built. Try: gem pristine rubysl-zlib --version 2.0.1
fatal: Not a git repository (or any of the parent directories): .git

@glebm

glebm commented Dec 7, 2017

Copy link
Copy Markdown
Owner

Thanks, looks good! I'll fix travis and rubocop errors after merging this

@glebm glebm merged commit bccf6a3 into glebm:master Dec 7, 2017
@glebm glebm added this to the v0.9.20 milestone Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.9.20

Development

Successfully merging this pull request may close these issues.

2 participants

@heironimus @glebm