Conversation
- assigned _glfw-qualified private names to all static symbols to avoid naming conflicts when including glfw3impl.h - added casts as needed to compile glfw3impl.h as C++ - replaced sprintf with snprintf to avoid warnings from clang -Wall, (except on win32, where this provokes an appveyor failure `'snprintf' undefined`) - Added a brief remark on `glfw3impl.h` to the `Compiling GLFW` section in `README.md` - Added `Garett Bass` to `CONTRIBUTORS.md`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #2462, but rebased into the 3.5.1 release (WIP at the moment).
Some newly introduced functions might be yet to be renamed to the
_glfw<function-name><platform>()pattern.It has been tested only briefly on Linux for now. It builds successfully with both Wayland and X11 using CMake and also as a unity build. It also builds successfully as a Windows executable from a unity build and a Linux host.
At the moment, when building as C++ with Wayland support, warnings about the "visibility" attribute are shown. Additionally, there is an error related to the types used with the
wl_array_for_each()macro. Apparently, this macro is not usable in C++ and the only alternative is to iterate the array manually.Maybe we can set aside the plans to make the code a valid subset of C++ for now and open a separate issue about this.
These are the steps to test a unity build on Linux supporting both Wayland and X11:
test.cin this example) that includesglfw3impl.h:If MinGW is installed, it can also be built as a Windows executable from a Linux host: