Conversation
This commit fixes the following issue: glfw#2900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2900
Only the behaviour of the CharMods callback is changed (fixed).
The Char and Key callbacks should be completely unaffected by this change.
The only plausible issue I could see arrising is if some input methods were
to allow users to compose codepoints from key press sequences which specifically
require a control key press.
I am fairly certain that such sequences do not exist within X11.
After all, the control key is not meant for composition (unlike Alt, Alt-Gr etc.).
Let me know if I should direct this PR at the 'latest' branch instead of 'master'.