(WIP) Add binby to compute_statistics#2130
Draft
jsub1 wants to merge 6 commits into
Draft
Conversation
… update tests to new api
…ute statistic instead of compute histogram. All of the tests pass as of now :)
… specifying a view
astrofrog
self-requested a review
April 29, 2020 15:11
astrofrog
removed their request for review
May 15, 2020 09:23
Member
|
@jsub1 - feel free to ping me once this is ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the API of compute_statistic to the one described in #1885, and uses the new compute_statistic to implement compute_histogram. There are some features missing (e.g. chunking and random subsets) and performance has not been tested yet.