Conversation
Updated UHD source reference from 4.10.0.0 to 4.11.0.0 and added new required grpc and protobuf dependencies to the conan requirements. Signed-off-by: Marian Koop <marian.koop@emerson.com>
Updated versions requirements for python build dependencies that changes because of updating from Qt5 to Qt6. Upgraded minimum conan version to support building Qt6 targets and disabled include Qt6 postgre sql plugin. That also required sourcing a conan profil referencing it as host and build profile when invoking the conan workflow step. Modified definition of cmake QT_FOUND variable and added passing QT_PLUGIN_PATH and QT6_INSTALL_BINS cmake variable values in the GRC build workflow step. Signed-off-by: Marian Koop <marian.koop@emerson.com>
|
I also enqueued another window bundle installer build at https://github.com/mkoop-ni/gnuradio/actions/runs/35291846892. |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the Windows bundle installer to use UHD 4.11.0.0 and refreshes the Qt6/Conan build configuration required for the newer dependency stack.
Changes:
- Upgrades UHD and its integrity hash.
- Updates Python packaging tools needed to build PyQt6 6.11.
- Adds Conan dependencies and a pinned MSVC C++17 profile for Windows builds.
- Adjusts Qt detection and Windows workflow configuration.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
release/requirements.txt |
Updates packaging, PyQt-builder, setuptools, and SIP versions. |
release/deps/deps/FetchAndBuildUHD.cmake |
Upgrades the bundled UHD source to 4.11.0.0. |
release/conanfile.txt |
Adds gRPC/protobuf dependencies and Qt options. |
release/conan/profiles/msvc_cppstd17_194 |
Adds the Windows MSVC C++17 Conan profile. |
gr-qtgui/CMakeLists.txt |
Uses the generic Qt6 package detection result. |
.github/workflows/win-installer-build.yml |
Pins Conan, applies the new profile, and configures Qt/UHD paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| set UHD_DIR=%CD%\deps\uhd | ||
| @echo Defining the environment variable UHD_DIR to allow UHDConfig.cmake | ||
| set UHD_DIR=%CD%\deps\uhd | ||
| @echo to detected the local UHD prefix at %UHD_DIR% |
|
Just found out that the qt GUI option is not working because the pyqt module did not get pulled in. |
Description
Declaration of Willingness To Own
(This is mandatory. If you can't build GNU Radio, please come talk to us before opening the PR.)
Related Issue
Which blocks/areas does this affect?
Testing Done
Build Bundle Installer in PR branch. See also earlier (pre-clean up) build https://github.com/mkoop-ni/gnuradio/actions/runs/35041810409
Checklist