Skip to content

Make docker gitea/gitea:v1.16-dev etc refer to the latest build on that branch (#18551) - #18569

Merged
zeripath merged 3 commits into
go-gitea:release/v1.16from
zeripath:backport-18551-v1.16
Feb 3, 2022
Merged

zeripath merged 3 commits into
go-gitea:release/v1.16from
zeripath:backport-18551-v1.16

Conversation

@zeripath

@zeripath zeripath commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Backport #18551

(Backporting this will enable drone to create the 1.16-dev docker tag)

One of the problems with our current docker tagging is that although we
have strict version tags, latest and dev we do not have a way for docker
users to track the current release branch. This PR simply suggests that
we use the 1.x-dev tag for these and we build and push these. This will
give users who want or need unreleased bug fixes the option of tracking
the pre-release version instead of simply jumping to dev.

Signed-off-by: Andrew Thornton art27@cantab.net
Co-authored-by: KN4CK3R admin@oldschoolhack.me
Co-authored-by: Lunny Xiao xiaolunwen@gmail.com

…at branch (go-gitea#18551)

Backport go-gitea#18551

(Backporting this will enable this target to create 1.16-dev)

One of the problems with our current docker tagging is that although we
have strict version tags, latest and dev we do not have a way for docker
users to track the current release branch. This PR simply suggests that
we use the 1.x-dev tag for these and we build and push these. This will
give users who want or need unreleased bug fixes the option of tracking
the pre-release version instead of simply jumping to dev.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Feb 3, 2022
@zeripath zeripath added this to the 1.16.1 milestone Feb 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 3, 2022
Comment thread docker/manifest.tmpl Outdated
@zeripath

zeripath commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

Also contains backport for #18573

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2022
@zeripath
zeripath merged commit e84a432 into go-gitea:release/v1.16 Feb 3, 2022
@zeripath
zeripath deleted the backport-18551-v1.16 branch February 3, 2022 12:00
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 3, 2022
…at branch (go-gitea#18551) (go-gitea#18569)

Backport go-gitea#18551

One of the problems with our current docker tagging is that although we
have strict version tags, latest and dev we do not have a way for docker
users to track the current release branch. This PR simply suggests that
we use the 1.x-dev tag for these and we build and push these. This will
give users who want or need unreleased bug fixes the option of tracking
the pre-release version instead of simply jumping to dev.

However, there is a problem with go-gitea#18551/go-gitea#18569 whereby the manifest is
not properly uploading. Therefore this PR adds in some debug logging
in order to get this to debug things.

Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny pushed a commit that referenced this pull request Feb 3, 2022
…at branch (#18551) (#18569) (#18575)

Backport #18551

One of the problems with our current docker tagging is that although we
have strict version tags, latest and dev we do not have a way for docker
users to track the current release branch. This PR simply suggests that
we use the 1.x-dev tag for these and we build and push these. This will
give users who want or need unreleased bug fixes the option of tracking
the pre-release version instead of simply jumping to dev.

However, there is a problem with #18551/#18569 whereby the manifest is
not properly uploading. Therefore this PR adds in some debug logging
in order to get this to debug things.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@delvh delvh added topic/distribution This PR changes something about the packaging of Gitea and removed theme/docker labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/distribution This PR changes something about the packaging of Gitea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants