Use test context in tests and new loop system in benchmarks#33648
Merged
Conversation
lunny
approved these changes
Feb 20, 2025
techknowlogick
approved these changes
Feb 20, 2025
hiifong
approved these changes
Feb 20, 2025
delvh
approved these changes
Feb 20, 2025
Contributor
-> Upgrade golangci-lint to v1.64.5 #33654 |
wxiaoguang
added a commit
that referenced
this pull request
Feb 20, 2025
Use `usetesting` instead of deprecated `tenv`. 1. Follow up #33648 2. Make lint pass and add some comments
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 21, 2025
* giteaofficial/main: Fix omitempty bug (go-gitea#33663) Upgrade golangci-lint to v1.64.5 (go-gitea#33654) Fix mCaptcha bug (go-gitea#33659) Update Go dependencies (skip blevesearch, meilisearch) (go-gitea#33655) Use test context in tests and new loop system in benchmarks (go-gitea#33648) Add missed changelogs (go-gitea#33649) [skip ci] Updated translations via Crowdin git graph: don't show detached commits (go-gitea#33645)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all contexts in tests with go1.24 t.Context()
I'd bump golangci-lint to 1.64.5 too but I'd have to add nolint rules on
cipher.NewCFBDecrypterandcipher.NewCFBEncrypterso it's better that someone who knows more about it looks at it.