I recommend also making it more strict and enable the default-disabled options:

linter-settings:
  usetesting:
    os-setenv: true
    os-temp-dir: true

I recommend also making it more strict and enable the default-disabled options:

IIRC they are enabled by default, that's why it needs this change: 6a5111d

Hmm, I see that os-temp-dir is different, it defaults to false. Will try to see how many changes we need to do to enable it.

If there are too many changes, then leave it to a new PR

Update: now os-temp-dir is enabled. (os-setenv is enabled by default, so no need to touch it)

And applied suggestions from #33655 (comment) for the Makefile

os-setenv is enabled by default, so no need to touch it

The docs say it's disabled by default. Is it a docs bug?

# Enable/disable `os.Setenv()` detections.
# Default: false
os-setenv: true

I think it is. The rule triggered for me but I figured that all those context changes + loop are big enough for a PR.
That and I had no confidence in replacing it so I left it alone.
Though it is strange - they generate those docs from their code so it should be up to date, given that changelog is there for later versions so it should be updated.

os-setenv is enabled by default, so no need to touch it

The docs say it's disabled by default. Is it a docs bug?

# Enable/disable `os.Setenv()` detections.
# Default: false
os-setenv: true

I do not think it is a bug. We are using golangci, but not the standalone usetesting

(Update: hmm, maybe usetesting doc is out-dated and it is a bug)

https://golangci-lint.run/usage/linters/#usetesting

Also see the doc screenshot in #33654 (comment)

Opened ldez/usetesting#7