Skip to content

Refactor repo-issue.ts#33784

Merged
wxiaoguang merged 4 commits into
go-gitea:mainfrom
wxiaoguang:refactor-repo-issue
Mar 4, 2025
Merged

Refactor repo-issue.ts#33784
wxiaoguang merged 4 commits into
go-gitea:mainfrom
wxiaoguang:refactor-repo-issue

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Mar 4, 2025 •
edited
Loading

And remove jQuery

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

wxiaoguang commented Mar 4, 2025 •
edited
Loading

Diff by ignoring spaces: https://github.com/go-gitea/gitea/pull/33784/files?diff=split&w=1

Manually tested:

View command line instructions

Details

image

Issue dependencies

Details

image

image

Toggle WIP

Details

image

image

Toggle WIP for new PR

Details

image

Update branch by merge/rebase

Details

image

Reference in new issue

Details

image

initRepoIssueComments

Unable to screenshot, see the comment

Show/hide out-dated, comment reply

Details

image

image

Markdown editor in issue template

Details

image

@wxiaoguang wxiaoguang force-pushed the refactor-repo-issue branch from 557aaa8 to 95d60f7 Compare March 4, 2025 10:48
@wxiaoguang wxiaoguang force-pushed the refactor-repo-issue branch from 95d60f7 to a23b342 Compare March 4, 2025 11:14
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 4, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 4, 2025
delvh
delvh approved these changes Mar 4, 2025
View reviewed changes
Comment thread web_src/js/features/repo-legacy.ts
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 4, 2025 17:19
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@wxiaoguang wxiaoguang merged commit 75e85c2 into go-gitea:main Mar 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@wxiaoguang wxiaoguang deleted the refactor-repo-issue branch March 4, 2025 18:00
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 5, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1f845db 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade golang net from 0.35.0 -> 0.36.0 (go-gitea#33795)
  Remove context from git struct (go-gitea#33793)
  Small refactor to reduce unnecessary database queries and remove duplicated functions (go-gitea#33779)
  Refactor repo-issue.ts (go-gitea#33784)
  Refactor repo-settings.ts (go-gitea#33785)
  Refactor admin/common.ts (go-gitea#33788)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @delvh @GiteaBot