Skip to content

Refactor admin/common.ts#33788

Merged
wxiaoguang merged 1 commit into
go-gitea:mainfrom
wxiaoguang:refactor-admin-ts
Mar 4, 2025
Merged

Refactor admin/common.ts#33788
wxiaoguang merged 1 commit into
go-gitea:mainfrom
wxiaoguang:refactor-admin-ts

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Only remove jQuery

Legacy code is still quite unclear, but I don't have time to do a full rewritting, so keep it as-is at the moment.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@wxiaoguang

wxiaoguang commented Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

Diff by ignoring spaces: https://github.com/go-gitea/gitea/pull/33788/files?diff=split&w=1

Manually tested:

  • Admin notice
  • Authentication Sources (new/edit)
  • Admin Users (new/edit)

@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 4, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@wxiaoguang wxiaoguang merged commit 163bbca into go-gitea:main Mar 4, 2025
@wxiaoguang wxiaoguang deleted the refactor-admin-ts branch March 4, 2025 15:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 5, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1f845db 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade golang net from 0.35.0 -> 0.36.0 (go-gitea#33795)
  Remove context from git struct (go-gitea#33793)
  Small refactor to reduce unnecessary database queries and remove duplicated functions (go-gitea#33779)
  Refactor repo-issue.ts (go-gitea#33784)
  Refactor repo-settings.ts (go-gitea#33785)
  Refactor admin/common.ts (go-gitea#33788)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @delvh @GiteaBot