feat(ui): add "follow rename" to file commit history list - #34994
Merged
Merged
Conversation
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
Contributor
Author
|
Thank you very much @wxiaoguang ! |
Member
|
Db test fail |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
routers/web/repo/commit.go:261
- When
commitsCount == -1(unknown total / follow-rename mode), the paginator needsWithCurRows(...)to decide whether there is a next page. Without it,HasNext()is always false (curRows defaults to 0), so the “next” link never appears even when there are more results. You can also use the computedhasMoreto avoid the paginator’s edge case where a full page on the last page would still show “next”.
pager := context.NewPagination(commitsCount, setting.Git.CommitsRangeSize, page, 5)
pager.AddParamFromRequest(ctx.Req)
ctx.Data["Page"] = pager
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
lunny
approved these changes
Jun 3, 2026
wxiaoguang
enabled auto-merge (squash)
June 3, 2026 17:23
wxiaoguang
disabled auto-merge
June 3, 2026 17:23
wxiaoguang
enabled auto-merge (squash)
June 3, 2026 17:23
wxiaoguang
disabled auto-merge
June 3, 2026 17:24
wxiaoguang
enabled auto-merge (squash)
June 3, 2026 17:24
Contributor
Author
|
@Taldariner @fish0x00 Here it is :) |
Contributor
Yes! 1.27 nightly can be downloaded here: |
zeekay
pushed a commit
to hanzoai/forge
that referenced
this pull request
Jul 26, 2026
…4994) Fix go-gitea#28253 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
pushed a commit
that referenced
this pull request
Aug 15, 2026
The dashboard activity feed was paginated with `[ui.user] REPO_PAGING_NUM` instead of `[ui] FEED_PAGING_NUM`. The wrong setting was picked up when the page size was hoisted into a local variable in #34994, most likely copied from the `dashboardRepoList` block a few lines above. `REPO_PAGING_NUM` should only control repository lists. Fixes #38925
bircni
added a commit
that referenced
this pull request
Aug 15, 2026
Backport #38935 by @bircni The dashboard activity feed was paginated with `[ui.user] REPO_PAGING_NUM` instead of `[ui] FEED_PAGING_NUM`. The wrong setting was picked up when the page size was hoisted into a local variable in #34994, most likely copied from the `dashboardRepoList` block a few lines above. `REPO_PAGING_NUM` should only control repository lists. Fixes #38925 Co-authored-by: bircni <bircni@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #28253