test(e2e): fix race in pdf file render test - #38380
Merged
Merged
Conversation
data-render-name is set before the plugin's async render runs, so measuring the container height right after the attribute appears can observe the pre-render 48px height when the pdfobject chunk loads slowly. Poll for the height instead, like the asciicast test does. Assisted-by: Claude Code:Fable-5
delvh
approved these changes
Jul 9, 2026
bircni
approved these changes
Jul 9, 2026
silverwind
commented
Jul 9, 2026
Signed-off-by: silverwind <me@silverwind.io>
silverwind
enabled auto-merge (squash)
July 9, 2026 12:46
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Stabilizes the PDF file-view E2E test by removing a race where height was asserted immediately after a render attribute appeared, sometimes observing a pre-render height in CI.
Changes:
- Replaces a one-time
boundingBox().heightassertion with a polling assertion to wait for the rendered height.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bircni
pushed a commit
that referenced
this pull request
Jul 9, 2026
Backport #38380 by @silverwind `data-render-name` is set before the plugin's async render runs, so measuring the container height right after the attribute appears can observe the pre-render 48px height when the `pdfobject` chunk loads slowly (flaked in CI). Poll for the height instead, like the asciicast test in the same file does. Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 9, 2026
* 'main' of https://github.com/go-gitea/gitea: (28 commits) enhance(actions): only create filtered-out workflow commit status for required contexts (go-gitea#38371) fix(ui): restore commits table column widths (go-gitea#38379) test(e2e): fix race in pdf file render test (go-gitea#38380) refactor: introduce ActivePageTimer to help to do partial page refresh (go-gitea#38372) [skip ci] Updated translations via Crowdin chore(typo): fix grammar in comments, API docs and error messages (go-gitea#38370) fix: golang html template url escaping (go-gitea#38363) perf(actions): debounce runner heartbeat writes and throttle task picks (go-gitea#38281) fix(mirror): disable HTTP redirects on pull mirror sync (go-gitea#38320) chore(deps): update dependency djlint to v1.40.1 (go-gitea#38354) fix(deps): update npm dependencies (go-gitea#38352) chore(deps): update action dependencies (go-gitea#38353) fix(deps): update go dependencies (go-gitea#38346) fix: minio init check (go-gitea#38355) fix(pulls): add `branch-name` option for `DEFAULT_TITLE_SOURCE` (go-gitea#38356) fix: org project view assignee list (go-gitea#38357) feat(webhook): add reviewer name to MS Teams review request notifications (go-gitea#38289) chore(deps): update action dependencies (go-gitea#38340) chore: Upgrade xorm to 1.4.1 (go-gitea#38224) chore(deps): update tool dependencies (go-gitea#38344) ...
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 9, 2026
* main: enhance(actions): only create filtered-out workflow commit status for required contexts (go-gitea#38371) fix(ui): restore commits table column widths (go-gitea#38379) test(e2e): fix race in pdf file render test (go-gitea#38380) refactor: introduce ActivePageTimer to help to do partial page refresh (go-gitea#38372) [skip ci] Updated translations via Crowdin chore(typo): fix grammar in comments, API docs and error messages (go-gitea#38370) fix: golang html template url escaping (go-gitea#38363) perf(actions): debounce runner heartbeat writes and throttle task picks (go-gitea#38281) fix(mirror): disable HTTP redirects on pull mirror sync (go-gitea#38320) chore(deps): update dependency djlint to v1.40.1 (go-gitea#38354) fix(deps): update npm dependencies (go-gitea#38352) chore(deps): update action dependencies (go-gitea#38353) fix(deps): update go dependencies (go-gitea#38346) fix: minio init check (go-gitea#38355) fix(pulls): add `branch-name` option for `DEFAULT_TITLE_SOURCE` (go-gitea#38356)
zeekay
pushed a commit
to hanzoai/forge
that referenced
this pull request
Jul 26, 2026
`data-render-name` is set before the plugin's async render runs, so measuring the container height right after the attribute appears can observe the pre-render 48px height when the `pdfobject` chunk loads slowly (flaked in CI). Poll for the height instead, like the asciicast test in the same file does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-render-nameis set before the plugin's async render runs, so measuring the container height right after the attribute appears can observe the pre-render 48px height when thepdfobjectchunk loads slowly (flaked in CI). Poll for the height instead, like the asciicast test in the same file does.