Repository navigation
data_source: snapshot readers so Append can reload - #404
Closed
team-humaki wants to merge 1 commit into
Closed
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Member
|
Thanks. Reading every reader up front keeps a copy of it for the life of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append stored io.Reader / ReadCloser sources as-is, then Reload closed them. A second Append (or Reload) failed with "file already closed" because those streams are not rewindable.
Read the bytes once when the source is ingested and keep a sourceData snapshot so later reloads can re-read. Fixes #324.