Repository navigation
Preserve comment markers inside quoted values - #414
Merged
unknwon merged 1 commit intoNov 11, 2026
Merged
Conversation
unknwon
force-pushed
the
fix/quoted-inline-comments-20261002
branch
from
November 11, 2026 20:03
d6a02d6 to
2bec834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not treat
#or;inside a surrounding single- or double-quoted value as an inline comment. A marker after the closing quote still starts the comment, and the parsed key retains the quoted value without its delimiters.Fixes #393.
Validation
go test ./... -count=1passed.go vet ./...andgit diff --checkpassed.