boolean keys do not get sanitised from the \n#77
Merged
Conversation
Author
|
patch provided!!! :) |
zeph
pushed a commit
to zeph/goad
that referenced
this pull request
Dec 21, 2016
as go-ini/ini has not yet merged my patch on booleanKeys (required to enable/disable regions) - go-ini/ini#77 - go-ini/ini#78
Member
|
Just one comment and the conflict, otherwise LGTM. |
… not get sanitized...
Author
|
@unknwon rebased and fixed |
Author
|
@unknwon is there anything else I need to provide? |
|
Will this be getting merged in? I'm getting hit with this issue :( |
unknwon
added a commit
that referenced
this pull request
Jan 22, 2017
Author
|
@prawnsalad seems it just got merged :) yay! |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would have loved to provide as well a patch...
I'll try, but maybe someone else is faster than me
here is a unit test that properly isolates the problem