Skip to content

Keys should not consider themself for transformation.#130

Merged
unknwon merged 1 commit into
go-ini:masterfrom
apauzies:master
Nov 14, 2017
Merged

Keys should not consider themself for transformation.#130
unknwon merged 1 commit into
go-ini:masterfrom
apauzies:master

Conversation

@apauzies

@apauzies apauzies commented Nov 13, 2017

Copy link
Copy Markdown
Contributor

What problem should be fixed?

NAME = ini
[package]
NAME = $(NAME)

I believe NAME in section [package] should evaluate to ini

Have you added test cases to catch the problem?

nope :/

@unknwon

unknwon commented Nov 14, 2017

Copy link
Copy Markdown
Member

Thank you!

@unknwon unknwon merged commit fa898e8 into go-ini:master Nov 14, 2017
unknwon added a commit that referenced this pull request Nov 14, 2017
@unknwon

unknwon commented Nov 14, 2017

Copy link
Copy Markdown
Member

I have added tests for you.

@apauzies

Copy link
Copy Markdown
Contributor Author

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants