Skip to content

Conversation

@ygj6
Copy link
Contributor

@ygj6 ygj6 commented Aug 1, 2020

What problem should be fixed?

fix #238
Add options to control sections insensitive or keys insensitive respectively.

Have you added test cases to catch the problem?

Yes,here are some test cases

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #253 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   86.25%   86.41%   +0.15%     
==========================================
  Files           9        9              
  Lines        1885     1885              
==========================================
+ Hits         1626     1629       +3     
+ Misses        198      196       -2     
+ Partials       61       60       -1     
Impacted Files Coverage Δ
ini.go 71.42% <ø> (ø)
file.go 85.62% <100.00%> (+0.93%) ⬆️
parser.go 85.14% <100.00%> (ø)
section.go 96.64% <100.00%> (ø)

@unknwon
Copy link
Member

unknwon commented Aug 13, 2020

Thanks for the PR! Would you mind fixing the conflicts?

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit f1d9ab1 into go-ini:master Aug 16, 2020
@unknwon
Copy link
Member

unknwon commented Aug 16, 2020

v1.59.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS config ini quirks

2 participants