Skip to content

Conversation

@ygj6
Copy link
Contributor

@ygj6 ygj6 commented Aug 10, 2020

What problem should be fixed?

fix #252
Fix deleting the default section makes the next section inaccessible.

Have you added test cases to catch the problem?

Yes,here are some test cases.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           9        9           
  Lines        1885     1885           
=======================================
  Hits         1626     1626           
  Misses        198      198           
  Partials       61       61           
Impacted Files Coverage Δ
file.go 84.68% <100.00%> (ø)

@unknwon
Copy link
Member

unknwon commented Aug 13, 2020

Thank you!

@unknwon unknwon changed the title file:fix deleting the default section makes the next section inaccessible file: fix deleting the default section makes the next section inaccessible Aug 13, 2020
@unknwon unknwon merged commit 1a3a8f7 into go-ini:master Aug 13, 2020
@unknwon
Copy link
Member

unknwon commented Aug 13, 2020

v1.58.0 has tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the default section is deleted, other sections become the default section

2 participants