Skip to content

file: fix deleting the default section makes the next section inaccessible #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unknwon merged 1 commit into from
Aug 13, 2020
Merged

file: fix deleting the default section makes the next section inaccessible #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func (f *File) writeToBuffer(indent string) (*bytes.Buffer, error) {
}
}

if i > 0 || DefaultHeader {
if i > 0 || DefaultHeader || (i == 0 && strings.ToUpper(sec.name) != DefaultSection) {
if _, err := buf.WriteString("[" + sname + "]" + LineBreak); err != nil {
return nil, err
}
Expand Down
19 changes: 19 additions & 0 deletions file_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,25 @@ func TestFile_DeleteSection(t *testing.T) {
f.DeleteSection("")
So(f.SectionStrings(), ShouldResemble, []string{"author", "package"})
})

Convey("Delete default section", t, func() {
f := ini.Empty()
So(f, ShouldNotBeNil)

f.Section("").Key("foo").SetValue("bar")
f.Section("section1").Key("key1").SetValue("value1")
f.DeleteSection("")
So(f.SectionStrings(), ShouldResemble, []string{"section1"})

var buf bytes.Buffer
_, err := f.WriteTo(&buf)
So(err, ShouldBeNil)

So(buf.String(), ShouldEqual, `[section1]
key1 = value1

`)
})
}

func TestFile_Append(t *testing.T) {
Expand Down